This won't work for in-content UI that loads remotely but there is no danger of the add-ons manager loading remotely for now. The add-ons manager can then walk further up to get the tab that that browser is contained in if necessary. ![]() It walks up the frame tree from the installing window to find the privileged browser element that contains the website and then passes that directly to the add-ons manager. Instead this patch makes us skip the message manager in the case that we're already running in the main process. Bug 1200742 means we can't change that right now. I can view a Gmail attachment, but if I attempt to download it, the browser crashes. Firefox and Safari crash every time I attempt to add an attachment to an email in Gmails web interface. The code the install paths use to send the messages all find the outer browser because the inner browser doesn't have a message manager. Firefox 40.0.3 and Safari 8.0.8 (10600.8.9) on Macbook Air 2012 running OS X Yosemite 10.10.5. ![]() In this case we should be doing the security checks against the inner browser and notifying UI about the outer browser so the doorhangers are parented correctly. The problem is that the AMO discovery pane runs in a inside the add-ons manager which is itself running inside a. ![]() Splinter Review The messages to chrome to start add-on installs all go through the content frame message manager and we use that to determine which browser triggered the install and so which browser to use for security checks and which tab to notify the UI about.
0 Comments
Leave a Reply. |
Details
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |